Python: convert script from procedural to OOP style -


I have written that this easy munin plugin has been written for the average fan speed of the graph and I have it in OOP again I want to - strictly as a drill to learn. There is no clue, although where to start, it seems like giving some directions to anyone or even an example of how this script should appear, when it is done, I will call it another script again I will use it again in OOP style; For re-learning purposes. 

  Import System Import Subprocess CMD = "/ USR / SBI / Omerport Chassis Fans" .split () #Munein sys.argv [1] to "" (an empty argument), remove it . Sys.argv = [xs.x for X in sys.argv] if len (sys.argv)> 1: If sys.argv [1]. Liquid () == "Autoconfig": print "Autoconfig" alip sys.argv [1]. Flowers () == "Config": Print "Graph_title Average Fan Speed" Print "Article - Base 1000-L" Print "Graph- Level Speed ​​(RPM)" Print "Graphic Chassis" Print "Graph_Inffa This article shows the average of all fans The speed indicates the duration of the "graph" graph - the second printing "speed". The average speed "speed" speed information is five minutes for average fan speed. "Else: Try: Data = Subprocess .POPN (CMD, Standout = Subprances. PPE ) .stdout.readlines () OSERRO, E: Print & gt; & Gt; Sys.stderr, "'% s',% s"% ("" .join (cmd), e) sys.exit (1) calculation = total = 0 error in running for item in data: if the item reads " ": Remove the variable length fan speed, without # ragges. Total + = intestine (item split (":") [1] .split () [0]) count + = 1 # OMOVERPORT sometimes returns omreport zero output when OMS service is not started. If not counting or not total: Print & gt; & Gt; Sys.stderr, 'Error: "Omwellport Chassis fans" returned 0 outputs. Print & gt; & Gt; Sys.stderr, 'Ohmasa going on? Try: "srvadmin-services.sh status". 'Sys.exit (1) average = (total / count) print "speed.value% s"% avg

You can remake and identify the code and data that runs simultaneously in OOP. After this you can merge into "Classes".

You seem to produce a process above the actual data. Code is running on it I think that you can create a square from it if you want but it is a bit silly :)

So, something like this (clearly completely Untested code): 

  import system import subprocess class Fanspeed (object): def __init __ (self, command): self .command = command.split () def average_fan_speed (self): data = Sub process. Popin (CMD, stdout = subprocess.PIPE) .stdout.readlines () Calculation = Total = 0 For items in data: If the "Reading" in the item: # Remove the variable length fan speed, without ragges. Total + = intestine (item split (":") [1] .split () [0]) count + = 1 # OMOVERPORT sometimes returns omreport zero output when OMS service is not started. If not counting or not total: increase the value ("I am not getting any fan." What OMSA services have started? Average = (total / calculated) return average% __main__ == '__main__': # Munin Sys.argv ["" (an empty argument), removes it. Sys.argv = [xs.x for x in sys.argv] if len (sys.argv)> 1: if sys.argv [ 1] .lower () = "Autoconfig": print "autoconfig" elif sys.argv [1]. Flower () == "config": print "graph_title average fan speed" print "graph_args --base 1000ll "Print" graph_vlabel speed (RPM) "print" graphic chassis "Q Untf "graph_info This article shows the average speed of all fans" print "graph_from at the other" print "speed. Label speed" print "speed.info average fan speed for five minutes." And: try: cmd = "/ usr / SBI / Omvelport Chassis fans "acclaimed = Fanspid (CMD) Evergue E = Acclaimed. Overage_fan_speed (except OSError, E: print> Sys.stderr," Error '% s,% s' % (Cmd, e) sys.exit (1) except ValueError, E: # occasionally omreport zero Tput gives prints that had started Omma service & gt; & Gt; Sys.stderr, 'Error: "Omwellport Chassis fans" returned 0 outputs. Print & gt; & Gt; Sys.stderr, 'Ohmasa going on? Try: "srvadmin-services.sh status". 'Sys.exit (1)

But YMMV is probably a bit obvious.


Comments

Post a Comment

Popular posts from this blog

sql - dynamically varied number of conditions in the 'where' statement using LINQ -

I am using my first project LINQ (in mvc), so maybe there's something very simple that I remember. However, a day of searching and experimenting does not work, so it works. I am trying to write a LINQ query (Linux to SQL) in which in many cases where the statement is different from an OR or an AND. We do not know how many conditions are going in the query till runtime. This search is for filter control, where the user can choose multiple criteria for filtering. Select from table where table.col = 1 or table.col = 2 or table.col = 7 .... 'Other number of conditions Before I just create the SQL query as a string, while looping over all the situations. However, it seems that there should be a good way to do this in LINQ. I tried to use Expression trees, but they had a second thought for this moment on my head, where the lambda function was to be executed inside the statement such as: values ​​for matchingRows = matchingRows for each value Where (function (row) row.c...
Read more

asp.net mvc - Dynamically Generated Ajax.BeginForm -

I have a problem with ASP.NET MVC Ajax forms. I generate many Ajax form in a table such as: & Lt; Input type = "submit" name = "activity" value = "add activity" / & gt; & Lt;%}% & gt; & Lt; / TD & gt; & Lt; / TR & gt; & Lt;%}% & gt; So far so good. When I post one of those forms, it gives a partial view in a div, and in this new partial view a new Ajax Beginnform (which is not in Genesis form) This second Ajax Beginnorf is exactly like the ones I got on the table, but when I post it, I do not get the "Ajax Post", but a normal post that sends me to a new page, I do not know whether the two Ajax forms What is the reason for the difference between, why is it the "dynamically generated" Ajax form behaves like a normal HTML form? By the way, I know that I can do it in different ways using javascript, but I would like to understand whether it can only be done using MVC helplars and Ajax lib...
Read more

Debug on symbian -

I am using trk for phone debug This works well for the Holorld project But when I start the project in phone debug mode 1) the load failed 2) TrkProtocolPlugin: to target the specified file Failure (please verify If any body understands what problem I am experiencing, then this problem helps me Pre-release If the application has the privileges assigned (with the appropriate certificate) itemprop = "text" > In your case, I will check: / li> If there is no conflict of application ID with any other application of device If there are problematic commands in the installation package (for example copy copy for non-accessible directories)
Read more