Python: feedback / corrections on first OOP style script -


I want some feedback on my first python script that uses the OOP style, it's a muni plugin that plugins (dell_fans, Dell_temps uses the average fan speed or average chassis floating graph based on the name.

An hour or so before that in the fan speed plugin, to get the help of stack overflow to convert it into an open style then I created the two scripts to combine any feedback, suggestions , Improvements will be very helpful

Updates : I would like to correct any misconceptions to be modified for the general base class. Any other suggestions? 

  Import System Import Subprocess Class Data (object): def __init __ (self, command): self.command = command.split () DEF average (self): data = subprocess.Popon ( Self.command, stdout = subprocess.PIPE) .stdout.readlines () Count = Total = 0 for item in data: If "read" in the item: #Executive length fan speed, without regex Total + = Float (item split (":") [1] .split () [0]) Count + = 1 # OMOVERPORT sometimes returns omreport zero output if OMS service is not started. If not counting or not total: Price increase ("There is no output from omreport." What does OMSA services have started?) Average = (total / calculated) Return Average Df print_autoconfig (self): Printed "AutoConfig goes here "Square fancy: stat __init __ (self, command): statistics .__ init __ (self, command) def print_config (self): print" graph_title average fan speed "print" graph_args --base 1000 -l 0 " Print "graphs / speed motion (rpm)" print "graph_category chassis" print " Af_Inffa This article shows the average speed of all fans "print" graphs_from other "print" data.The speed of the label "print" data.info average fan speed for five minutes. "Class temps (statistics): def __init __ (self , Command): statistics .__ init __ (self, command) def print_config (self): print "graph_title average temperature" print "graph_args -upper-limit 120 -l 0" print "graph_vlabel celsius" print "graph_class chassis" print " Graph_info This article contains all sensors Reflects the average temperature of the "print" graph_precious second "print" data. Label temp "print" data.info average chassis temperature for five minutes. " If __name__ == '__main__': #munein sowsargs [1] with "" (an empty argument), it removes it. Sys.argv = [xs.x for X in sys.argv] "fans" in sys.argv [0]: CMD = "/ USR / SBI / Omerport chassis fans" omdata = fanpid (CMD) alip "temps" In Sys.argv [0]: cmd = "/ usr / sbin / omreport chassis temps" omdata = Temps (cmd) Other: Print & gt; & Gt; Sys.stderr, "File name changed to dell_fans or dell_temps." Sys.exit (1) if LAN (sys.argv) & gt; 1: If sys.argv [1] .lower () == "autoconfig": omdata.print_autoconfig () elif sys.argv [1]. Flowers () == "config": omdata.print_config () and: try: average = omdata.average () print "data.value% s" OSError, e: print & gt; & Gt; Sys.stderr, "Error in running error"% s,% s "% (cmd, e) sys.exit (1) except ValueError, E: # Occasionally omreport returns zero output if omma service is not started Print & gt; & Gt; Sys.stderr, 'Error: "Omwellport Chassis fans" returned 0 outputs. Print & gt; & Gt; Sys.stderr, 'Ohmasa going on? Try: "srvadmin-services.sh status". ' Temps

temps A FanSpeed ​​? It is a litmus test whether sub-clinging is appropriate (for example an elephant is an animal, a car is not an animal - so it may be appropriate to have a subclass of animal Elephant, but not the sub-class of Animal which model the car.)

It seems that they are modeling two different things - Yes, create a common base class for them.


Comments

Post a Comment

Popular posts from this blog

sql - dynamically varied number of conditions in the 'where' statement using LINQ -

I am using my first project LINQ (in mvc), so maybe there's something very simple that I remember. However, a day of searching and experimenting does not work, so it works. I am trying to write a LINQ query (Linux to SQL) in which in many cases where the statement is different from an OR or an AND. We do not know how many conditions are going in the query till runtime. This search is for filter control, where the user can choose multiple criteria for filtering. Select from table where table.col = 1 or table.col = 2 or table.col = 7 .... 'Other number of conditions Before I just create the SQL query as a string, while looping over all the situations. However, it seems that there should be a good way to do this in LINQ. I tried to use Expression trees, but they had a second thought for this moment on my head, where the lambda function was to be executed inside the statement such as: values ​​for matchingRows = matchingRows for each value Where (function (row) row.c...
Read more

asp.net mvc - Dynamically Generated Ajax.BeginForm -

I have a problem with ASP.NET MVC Ajax forms. I generate many Ajax form in a table such as: & Lt; Input type = "submit" name = "activity" value = "add activity" / & gt; & Lt;%}% & gt; & Lt; / TD & gt; & Lt; / TR & gt; & Lt;%}% & gt; So far so good. When I post one of those forms, it gives a partial view in a div, and in this new partial view a new Ajax Beginnform (which is not in Genesis form) This second Ajax Beginnorf is exactly like the ones I got on the table, but when I post it, I do not get the "Ajax Post", but a normal post that sends me to a new page, I do not know whether the two Ajax forms What is the reason for the difference between, why is it the "dynamically generated" Ajax form behaves like a normal HTML form? By the way, I know that I can do it in different ways using javascript, but I would like to understand whether it can only be done using MVC helplars and Ajax lib...
Read more

Debug on symbian -

I am using trk for phone debug This works well for the Holorld project But when I start the project in phone debug mode 1) the load failed 2) TrkProtocolPlugin: to target the specified file Failure (please verify If any body understands what problem I am experiencing, then this problem helps me Pre-release If the application has the privileges assigned (with the appropriate certificate) itemprop = "text" > In your case, I will check: / li> If there is no conflict of application ID with any other application of device If there are problematic commands in the installation package (for example copy copy for non-accessible directories)
Read more